HomePhorge

(#7624) Manually fetch all properties in instances.
d4e6c268aecaUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#7624) Manually fetch all properties in instances.

When we removed the :audit => :all flag on creation of an instance from a
Puppet type, we stopped fetching all the properties. This had flow-on
consequences that were visible from the outside; while some places did their
own work to ensure that properties were fetched, others didn't.

We now open-code the loop that creates and fetches those properties, to ensure
that we have the same data without going through the :audit machinery.

This resolves the excessive logging, and also eliminates the behavioural
change that we introduced in the previous commit.

Reviewed-By: Daniel Pittman <daniel@puppetlabs.com>

Details

Provenance
Luke Kaines <luke@puppetlabs.com>Authored on
Daniel Pittman <daniel@puppetlabs.com>Committed on Jun 7 2011, 12:33 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUc5448b79e690: (#7624) Auditing should not be enabled by default for purged resources.
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPUd4e6c268aeca: (#7624) Manually fetch all properties in instances. (authored by Luke Kaines <luke@puppetlabs.com>).Jun 7 2011, 12:33 AM