HomePhorge

(#9435) Gracefully handle when syslog feature is unavailable
d34d28d6445dUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#9435) Gracefully handle when syslog feature is unavailable

Previously, if puppet is run without setting a log destination, it
always create a syslog log destination. This fails on Windows, because
the Syslog module is not available.

This commit adds the ability for a log destination type to say whether
it is suitable or not. If the destination is not suitable, then
Puppet::Util::Log.newdestination(obj) is a no-op. In the case of
syslog, it is only suitable if the syslog feature is enabled.

The reason for making the change this way, is that we don't want to
check whether the syslog feature is available everytime the log
destination is asked to handle a log message.

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUf013c65ca84d: (#9435) Fix absolute path matching for file log destinations
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPUd34d28d6445d: (#9435) Gracefully handle when syslog feature is unavailable (authored by Josh Cooper <josh@puppetlabs.com>).Sep 13 2011, 8:44 PM