HomePhorge

(PUP-2344) Extract methods to make flow clearer
cf5359101537Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-2344) Extract methods to make flow clearer

There were multiple levels happening in the different methods and some
LoD violations. By extracting some methods onto the LoaderModuleData
class and pulling out methods for the different kinds of dependency
loader creations the flow becomes a little clearer.

This also removes the TODOs since I think that the current
implementation is the right way to go.

Details

Provenance
Andrew Parker <andy@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU7832ce8d25f8: (maint) Clean up loader tests a little
Branches
Unknown
Tags
Unknown

Event Timeline

Andrew Parker <andy@puppetlabs.com> committed rPUcf5359101537: (PUP-2344) Extract methods to make flow clearer (authored by Andrew Parker <andy@puppetlabs.com>).Apr 26 2014, 2:56 AM