HomePhorge

(#8410) Cleanup and fix Windows support in Puppet::Util.execute
cb53870a8546Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#8410) Cleanup and fix Windows support in Puppet::Util.execute

The primary change in this commit is fixing the support for Windows in
Puppet::Util.execute. However, properly testing this commit required
significant refactoring (which was long overdue for this old code) for
testability.

The functionality for executing on posix and windows was extracted into
platform-specific methods, execute_posix and execute_windows. These
methods are self-contained and will both return the PID of the child
process, which the caller then waits on before reading and returning the
output of the command.

Details

Provenance
Nick Lewis <nick@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU39a582b1ab92: (#8410) Use absolute_path? for Puppet::Parameter::Path validation
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Lewis <nick@puppetlabs.com> committed rPUcb53870a8546: (#8410) Cleanup and fix Windows support in Puppet::Util.execute (authored by Nick Lewis <nick@puppetlabs.com>).Aug 24 2011, 7:56 PM