HomePhorge

(PUP-3379) Don't retry if block raises fatal error
c210b884c975Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-3379) Don't retry if block raises fatal error

Previously, if the caller didn't specify which exceptions to retry, the
retry_action method would retry all exceptions, even SystemExit and
NoMemoryError, which should never be rescued.

This method modifies the retry_action method to always re-raise
SystemExit and NoMemoryError, even in the situation where the caller
asks for them to be retried.

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU35b5c7c96559: (PUP-3379) Don't mutate caller's arguments
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPUc210b884c975: (PUP-3379) Don't retry if block raises fatal error (authored by Josh Cooper <josh@puppetlabs.com>).Dec 4 2014, 1:00 AM