HomePhorge

(PUP-2700) Fix regression in file_content requests
bfec60f4f2b3Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-2700) Fix regression in file_content requests

The resolution of PUP-1892 caused percent encoding of file_content requests to
be doubled. This created a regression where Puppet file servers would respond
with a 404 not found status unless multiple decode operations were applied.

This patch fixes the issue by building the file_content indirector request
directly from the file source parameter instead of casting it to an escaped
URI. The Indirector::Request class handles the necessary URI escaping during
initialization.

Details

Provenance
Charlie Sharpsteen <chuck@puppetlabs.com>Authored on
Charlie Sharpsteen <Charlie Sharpsteen chuck@puppetlabs.com>Committed on Jun 16 2014, 9:38 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUee63062dad28: (maint) Refactor file content remote source specs
Branches
Unknown
Tags
Unknown

Event Timeline

Charlie Sharpsteen <Charlie Sharpsteen chuck@puppetlabs.com> committed rPUbfec60f4f2b3: (PUP-2700) Fix regression in file_content requests (authored by Charlie Sharpsteen <chuck@puppetlabs.com>).Jun 16 2014, 9:38 PM