HomePhorge

Fix for #2910 -- Tidy/matches is too tricky to use
bcde541e4433Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Fix for #2910 -- Tidy/matches is too tricky to use

The semantic interaction of tidy/matches and tidy/recurse is tricky to get
right; it only makes sense to use matches with recursion (a fixed path will
either statically match or it won't, no need for a run-time check) but there
was nothing to warn users of this fact. To compound matters, the example
in the matches parameter doc string even made this mistake.

This patch: 1) fixes the doc string; 2) prohibits the use of match without a
value of recurse capable of generating files to match, 3) fixes tests that
were passing for the wrong reason and adds tests on the prohibition added
in (2).

Details

Provenance
Markus Roberts <Markus@reality.com>Authored on
James Turnbull <james@lovedthanlost.net>Committed on May 2 2010, 9:58 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU5abe571e1677: Bug #3451: Don't leak the terminus class setting from Puppet::Resource…
Branches
Unknown
Tags
Unknown

Event Timeline

James Turnbull <james@lovedthanlost.net> committed rPUbcde541e4433: Fix for #2910 -- Tidy/matches is too tricky to use (authored by Markus Roberts <Markus@reality.com>).May 2 2010, 9:58 AM