HomePhorge

(maint) Fix problems when rspec-puppet and rspec-helper are both used
b9ccadc215e5Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(maint) Fix problems when rspec-puppet and rspec-helper are both used

This fixes a problem that arises when there is more than one
puppet test infrasturcutre "orchestrator"; e.g. rspec-puppet and
rspec-helper. They both add calls to the TestHelper and this ends up
setting up and tearing down the puppet environment for each test.

This problem has existed for a long time, but was noticed when using the
new mark/rollback to ensure test consistency.

The fix os to add a re-entrance check for before_each and after_each to
ensure that they only do the job once even if registered to be called
a number of times.

Details

Provenance
Henrik Lindberg <henrik.lindberg@cloudsmith.com>Authored on
Kylo Ginsberg <kylo@puppetlabs.com>Committed on May 21 2014, 3:43 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUa901afdd5f8f: Merge pull request #2672 from peterhuene/pup/2182
Branches
Unknown
Tags
Unknown

Event Timeline

Kylo Ginsberg <kylo@puppetlabs.com> committed rPUb9ccadc215e5: (maint) Fix problems when rspec-puppet and rspec-helper are both used (authored by Henrik Lindberg <henrik.lindberg@cloudsmith.com>).May 21 2014, 3:43 AM