HomePhorge

Refactoring how the Settings file is parsed
b800bde30bd5Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Refactoring how the Settings file is parsed

The goal of this refactor was to use a cached attribute
for the LoadedFile instance we use to monitor whether
the file needs reparsing. We were getting tests that
affected later tests because they were holding on to
LoadedFile stubs, somehow.

The other main change here is that the Settings#parse
method now knows how to look up its own file path.

Signed-off-by: Luke Kanies <luke@madstop.com>

Details

Provenance
Luke Kanies <luke@madstop.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUd7864bedafcc: Relying on 'should_parse_config' in the 'puppet' application
Branches
Unknown
Tags
Unknown

Event Timeline

Luke Kanies <luke@madstop.com> committed rPUb800bde30bd5: Refactoring how the Settings file is parsed (authored by Luke Kanies <luke@madstop.com>).Feb 20 2009, 12:51 AM