HomePhorge

(PUP-2738) Windows utils appropriate return values
b5a7c27e3f25Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-2738) Windows utils appropriate return values

  • Puppet::Util::Windows::File.open_symlink was previously returning the integer result of CloseHandle, which was undesireable. Assume the token is always used in a block, so return nil from the method.
  • Puppet::Util::Windows::File.readlink was being a bit dangerous, and performing a non-local return within a block. Use a closure instead to capture the return value of resolve_symlink, return outside block.
  • Puppet::Util::Windows::Process.open_procss_token had the same issue as open_symlink, and has been changed to return nil.

Details

Provenance
Ethan J. Brown <Iristyle@github>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU0673d5441763: (PUP-2738) Use block form of FFI::MemoryPointer
Branches
Unknown
Tags
Unknown

Event Timeline

Ethan J. Brown <Iristyle@github> committed rPUb5a7c27e3f25: (PUP-2738) Windows utils appropriate return values (authored by Ethan J. Brown <Iristyle@github>).Jun 18 2014, 9:16 PM