HomePhorge

(#6407) Fix spec test hang with Mocha >= 0.9.11 in zlib testing
b311651526c7Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#6407) Fix spec test hang with Mocha >= 0.9.11 in zlib testing

We had a combination of bad logic, and bad testing, and a nasty behaviour of
Mocha <= 0.9.10 that would result in a false pass for one of our tests.

This not only falsely passed, but hid an infinite loop retrying decompression
on an invalid data stream; it could be triggered by anything that sent an HTTP
request with an invalid compressed body, resulting in a livelock.

Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@rimspace.net>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUaf2c85b5a98b: (#6551) remove deprecated 'env' parameter to the 'exec' type
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@rimspace.net> committed rPUb311651526c7: (#6407) Fix spec test hang with Mocha >= 0.9.11 in zlib testing (authored by Daniel Pittman <daniel@rimspace.net>).Mar 4 2011, 12:43 AM