HomePhorge

(#7282) action without `when_invoked` should fail...
b23cc8abec1aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#7282) action without when_invoked should fail...

We used to let actions be declared without the when_invoked block, which was
usually a sign of either someone writing their method code direct in action
declaration, or someone forgetting to add their code at all.

This was just let silently by: the error only showed up when you finally tried
to invoke the action, and a NoMethod error was raised by the face.

...except for our own testing. We took advantage of this a whole pile of
times in there; fixing the original UI issue means fixing all those too.

Reviewed-By: Nick Lewis <nick@puppetlabs.com>

Details

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPUb23cc8abec1a: (#7282) action without `when_invoked` should fail... (authored by Daniel Pittman <daniel@puppetlabs.com>).May 2 2011, 7:08 PM