HomePhorge

(PUP-3203) Don't mutate trigger when checking for equality
a51c6faa78d3Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-3203) Don't mutate trigger when checking for equality

Previously, when checking if the current and desired triggers were
equivalent, we were silently deleting the index and enabled values from
the current trigger. If we later needed to delete the current
trigger, we would have lost its index, resulting in a call to
Win32::TaskScheduler.delete_trigger(nil) causing the error:

no implicit conversion from nil to integer

This commit ensure that we don't mutate the current or desired trigger.

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
Rob Reynolds <ferventcoder@gmail.com>Committed on Oct 9 2014, 8:45 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU522ac8d140f7: Merge pull request #3158 from joshcooper/ticket/stable/PUP-1165-task-scheduler
Branches
Unknown
Tags
Unknown

Event Timeline

Rob Reynolds <ferventcoder@gmail.com> committed rPUa51c6faa78d3: (PUP-3203) Don't mutate trigger when checking for equality (authored by Josh Cooper <josh@puppetlabs.com>).Oct 9 2014, 8:45 PM