HomePhorge

(PUP-3912) Change 'describe' blocks to 'context' blocks
a00f82c81ec0Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-3912) Change 'describe' blocks to 'context' blocks

Previously there were spec tests with a 'describe' inside a 'describe',
which was fine and unambiguous as long as the inner 'describe' blocks
didn't make use of 'described_class'. However, rspec 3 consistently
treats the inner 'describe' as the source for the 'described_class',
which can lead to nonsense assertions with nested describes.

So this commit changes inner 'describe's to 'context's where needed
to make 'described_class' apply properly. Further, for internal consistency
within a file, all describes of a given depth or deeper that were
intended to be contexts were renamed as well.

Details

Provenance
Kylo Ginsberg <kylo@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU1eaa74f8d0b9: (PUP-3912) Replace 'double' with 'stub' for rspec 3
Branches
Unknown
Tags
Unknown

Event Timeline

Kylo Ginsberg <kylo@puppetlabs.com> committed rPUa00f82c81ec0: (PUP-3912) Change 'describe' blocks to 'context' blocks (authored by Kylo Ginsberg <kylo@puppetlabs.com>).Jan 26 2015, 8:52 PM