HomePhorge

maint: spec/integration/configurer has races in time checking.
9a1c3b5ad48aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

maint: spec/integration/configurer has races in time checking.

This code depended on the time written by the configurer, and Time.now about
half a dozen lines later, being the same integer value. This would work
almost all the time, because our code is pretty fast, but can race.

We now capture the time on both sides of the call, and verify that the emitted
time was in that range; this actually tests the whole purpose much better, and
more thoroughly.

Reviewed-by: Paul Berry <paul@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@rimspace.net>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU28095d7435bc: Merge branch '2.6.next' into next
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@rimspace.net> committed rPU9a1c3b5ad48a: maint: spec/integration/configurer has races in time checking. (authored by Daniel Pittman <daniel@rimspace.net>).Mar 8 2011, 3:44 AM