HomePhorge

[#4242] Fixed recursion due to parents including their children
9778f2a47922Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

[#4242] Fixed recursion due to parents including their children

Resources mark themselves as evaluated to prevent being evaluated
again. Unfortunately, they were not marking themselves until after
they had finished being completely evaluated. Thus, there was
nothing actually stopping recursive evaluations. This patch just
makes resources mark themselves as evaluated when they start
evaluating, and adds tests.

The original setting of evaluated was done in an ensure block, so
this doesn't change the behavior of a resource which fails to
evaluate. The only places evaluated? is checked aren't affected
by this change, as they wouldn't want to evaluate it when it's
already being evaluated anyway.

Details

Provenance
Nick Lewis <nick@puppetlabs.com>Authored on
Markus Roberts <Markus@reality.com>Committed on Jul 26 2010, 7:24 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU59a23d69c20a: Fix for #3382 -- Empty classes as graph placeholders
Branches
Unknown
Tags
Unknown

Event Timeline

Markus Roberts <Markus@reality.com> committed rPU9778f2a47922: [#4242] Fixed recursion due to parents including their children (authored by Nick Lewis <nick@puppetlabs.com>).Jul 26 2010, 7:24 AM