HomePhorge

(#6364) Adjust mis-translated regex in mount provider for AIX
960890f6ac6bUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#6364) Adjust mis-translated regex in mount provider for AIX

The commit to simplify the regex used to parse the output from the mount
command on AIX (50c12e55b6f8462f6904ae061e661d1d10c7590a) mis-translated
it.

The original regex was grabbing the 3rd space-separated element, not the
2nd. This mis-translation caused the provider to grab the device
information instead of the mount point, and compare that to the desired
mount point. This would cause Puppet to think that the mount was never
actually mounted under normal circumstances.

The code from 50c12e5 was passing the tests because the fixture data did
not include the mandatory leading whitespace that the original regex was
looking for. The updated fixture data is pulled from the mount manpage
from AIX v6r1.

Reviewed-by: Paul Berry <paul@puppetlabs.com>

Details

Provenance
Jacob Helwig <jacob@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU9e0f9c5cfecf: Updated CHANGELOG for 2.6.5rc4
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPU960890f6ac6b: (#6364) Adjust mis-translated regex in mount provider for AIX (authored by Jacob Helwig <jacob@puppetlabs.com>).Feb 18 2011, 8:30 PM