HomePhorge

Fix #5252 - line number mis-attribution during parsing
9604f1c4cd5aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix #5252 - line number mis-attribution during parsing

It is a resurgence of #2366 that appeared because of the commit
8971d8.

Before this commit, for associating documentation comments, we
were preferring line numbers coming from the parser currently reducing rule,
instead of the current lexer line number (which can be in advance
of several tokens due to the nature of LALR parsers).

We now merge the ast line number before fetching the comment from the
lexer.

Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>

Details

Provenance
Brice Figureau <brice-puppet@daysofwonder.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUcc5224c1912f: Maint. fix for test broken by 00eedac5
Branches
Unknown
Tags
Unknown

Event Timeline

Brice Figureau <brice-puppet@daysofwonder.com> committed rPU9604f1c4cd5a: Fix #5252 - line number mis-attribution during parsing (authored by Brice Figureau <brice-puppet@daysofwonder.com>).Nov 11 2010, 3:51 PM