HomePhorge

(#8663) Disable spec tests for unsupported functionality on Windows
925af9586a0eUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#8663) Disable spec tests for unsupported functionality on Windows

The mount, shell, and ssh_authorized_key types are not supported on
Windows, so these spec tests have been disabled when running on
Windows.

One of the compiler spec tests fails on Windows because
Puppet::Util.execute attempts to execute a program named "git rev-parse
HEAD". This has different semantics than Unix, where the command is
splatted, Kernel.exec(*command). Since this truly is a Windows bug, I
removed the fails_on_windows tag and updated ticket #8410.

Reviewed-by: Jacob Helwig <jacob@puppetlabs.com>
(cherry picked from commit d9ce88d10707268fe41c8f3ad1166137fe8e202f)

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
Jacob Helwig <jacob@puppetlabs.com>Committed on Aug 19 2011, 10:52 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU04965d7d7a9c: (#8663) Drive letters are not valid absolute paths on Windows
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPU925af9586a0e: (#8663) Disable spec tests for unsupported functionality on Windows (authored by Josh Cooper <josh@puppetlabs.com>).Aug 19 2011, 10:52 PM