Property Spec cleanup: extract mock provider to let method.

This helps eliminate member variables in tests, making it easier to see where
state is or isn't shared between tests.

Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>