HomePhorge

(#5710) Removed unnecessary calls to insync?
8f314f2bb14dUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#5710) Removed unnecessary calls to insync?

In the resource harness, we were calling insync? on all properties of
a resource, even if those properties weren't being managed. This was
unsafe. Changed to only call insync? on properties that are mentioned
in the manifest.

In addition, we discovered that the resource harness's computation of
desired_values was incorrect, and was consulting the current system
state rather than the desired state. Since this hash was
(erroneously) only being consulted to see if it included :ensure, this
didn't cause any obvious bugs. However it is now fixed.

Paired-with: Jesse Wolfe <jesse@puppetlabs.com>

Details

Provenance
Paul Berry <paul@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUe2700869a98e: Prep for fixing #5710: Refactor stub provider in resource harness spec
Branches
Unknown
Tags
Unknown

Event Timeline

Paul Berry <paul@puppetlabs.com> committed rPU8f314f2bb14d: (#5710) Removed unnecessary calls to insync? (authored by Paul Berry <paul@puppetlabs.com>).Jan 8 2011, 12:46 AM