HomePhorge

(PUP-2505) Reject requests with unknown HTTP verbs
8cba197c8dd9Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-2505) Reject requests with unknown HTTP verbs

When we forgot to handle DELETE the error showed up as a 500 because the
code tried to call a method on nil. The correct response is a 405, since
the server does not handle that method. Now that GET, POST, PUT, HEAD,
and DELETE are all covered, it should be safe to respond with 405 in all
other cases.

Details

Provenance
Andrew Parker <andy@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUa5ec7e5544d0: (PUP-2505) Add test for delete handling
Branches
Unknown
Tags
Unknown

Event Timeline

Andrew Parker <andy@puppetlabs.com> committed rPU8cba197c8dd9: (PUP-2505) Reject requests with unknown HTTP verbs (authored by Andrew Parker <andy@puppetlabs.com>).May 16 2014, 12:29 AM