HomePhorge

(#8272) Use symbols instead of booleans for enabled property on Windows
881c3858e88bUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#8272) Use symbols instead of booleans for enabled property on Windows

Because the enable property of the service type uses :true and :false as its
valid values, rather than true and false, we need to return :true and :false
from our enabled? method. Otherwise, the property was being synced every time
it was enabled or disabled, regardless of whether it was actually in sync or
not.

Reviewed-By: Jacob Helwig <jacob@puppetlabs.com>
(cherry picked from commit 44e2d494f499e2005c1b31b92b97834189d4224d)

Details

Provenance
Nick Lewis <nick@puppetlabs.com>Authored on
Jacob Helwig <jacob@puppetlabs.com>Committed on Aug 19 2011, 10:52 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU9c575bd9106b: (#8272) Fixup logging in Windows service provider
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPU881c3858e88b: (#8272) Use symbols instead of booleans for enabled property on Windows (authored by Nick Lewis <nick@puppetlabs.com>).Aug 19 2011, 10:52 PM