HomePhorge

(#9051) de-ActiveRecord-ify Collection expressions.
87006825f92dUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#9051) de-ActiveRecord-ify Collection expressions.

The original collection expressions built the ActiveRecord level SQL query
directly during AST evaluation, then returned that up to the collection and
ended up injecting it directly into the SQL query in the end.

Now that we have an abstract terminus for performing the query, it makes sense
to have an abstract definition of the query. Instead of SQL as a string the
collexpr AST entity now returns a data structure containing the desired
filter.

This allows the individual terminus to transform that into the appropriate
query expression for their data store, or otherwise evaluate the requested
filter on their own.

Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUbc5f1e3a6c3a: (#9051) Port query tests into the indirection.
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPU87006825f92d: (#9051) de-ActiveRecord-ify Collection expressions. (authored by Daniel Pittman <daniel@puppetlabs.com>).Aug 26 2011, 2:16 AM