HomePhorge

(#7259) Remove ActiveRecord requirement from indirector face spec
83c756367ef4Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#7259) Remove ActiveRecord requirement from indirector face spec

"should be able to return a list of terminuses for a given
indirection" was calling Puppet::Indirector::Face.terminus_classes,
which is just a thin wrapper around
Puppet::Indirector::Terminus.terminus_classes, which would attempt to
load all Terminus classes. This would cause problems if not all of
the prerequisites for all of the Terminus classes were installed (For
example: ActiveRecord).

Now we only test that the thin wrapper appropriately munges the output
from Puppet::Indirector::Terminus.terminus_classes, since the method
being wrapped should have its own tests for the behavior that was
being tested originally.

Paired-with: Nick Lewis <nick@puppetlabs.com>

Details

Provenance
Jacob Helwig <jacob@puppetlabs.com>Authored on
Pieter van de Bruggen <pieter@puppetlabs.com>Committed on May 19 2011, 12:44 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUaad2fd780b51: (#7259) Do not try to load all Terminus classes when configuring the Indirector
Branches
Unknown
Tags
Unknown

Event Timeline

Pieter van de Bruggen <pieter@puppetlabs.com> committed rPU83c756367ef4: (#7259) Remove ActiveRecord requirement from indirector face spec (authored by Jacob Helwig <jacob@puppetlabs.com>).May 19 2011, 12:44 AM