HomePhorge

(#8663) Exclude git rev-parse HEAD spec test on Windows
80092091fb98Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#8663) Exclude git rev-parse HEAD spec test on Windows

When running spec/integration/parser/compiler_spec.rb, the git command
passed to Puppet::Util.execute is an array containing a single string
["git rev-parse HEAD"]. On Unix, it calls Kernel.exec(*command), but on
Windows it calls Process.create(:command_line =>command), which attempts
to execute the program called "git rev-parse HEAD" and fails:

CreateProcess() failed: The system cannot find the file specified.

This commit marks the test as fails_on_windows, and will be re-enabled
when #8410 is fixed.

Reviewed-by: Nick Lewis <nick@puppetlabs.com>
(cherry picked from commit 7ca187509ce954e5b2707212a5615dbb9eb20378)

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
Jacob Helwig <jacob@puppetlabs.com>Committed on Aug 19 2011, 10:52 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUa0013e4b2d80: Check for the appropriate permissions in File type tests on Windows
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPU80092091fb98: (#8663) Exclude git rev-parse HEAD spec test on Windows (authored by Josh Cooper <josh@puppetlabs.com>).Aug 19 2011, 10:52 PM