HomePhorge

(PUP-4511) Ensure that unspecified contained types default to Any
7fee68ca3e11Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-4511) Ensure that unspecified contained types default to Any

The Array, Hash, and Optional all have contained types that may
be nil. The TypeCalculator.assignable? method didn't handle this
well (it passed nil in a recursive call to assignable?, an
operation that is permitted but will yield a false result).

This commit adds checks to ensure that if the contained type is nil,
then it will be considered to be of type Any.

Some tests were changed to accomodate the fact that Optional[?] now
considers everything to be assignable whereas nothing was assignable
before.

Details

Provenance
Thomas Hallgren <thomas@tada.se>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU17b75e2104c4: Merge pull request #3862 from melissa/maint/master/rm-lucid
Branches
Unknown
Tags
Unknown

Event Timeline

Thomas Hallgren <thomas@tada.se> committed rPU7fee68ca3e11: (PUP-4511) Ensure that unspecified contained types default to Any (authored by Thomas Hallgren <thomas@tada.se>).May 1 2015, 3:27 PM