HomePhorge

Alternate, and portable, stubbing of execution for upstart spec.
7da2c58545f5Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Alternate, and portable, stubbing of execution for upstart spec.

Previously this spec used to execute an external command in order to set the
Ruby $? global to a Process::Status object with a successful exit. This
was fine, but not portable to Windows, and not exactly efficient.

Instead, we now stub the exitcode on the $? object, whatever it is, to report
successful exit, and carry on. That works, stubbing the instance, to make
this both fairly robust and entirely portable.

Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUec3bba570537: Merge pull request #433 from pcarlisle/ticket/2.7.x/12268-upstart
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPU7da2c58545f5: Alternate, and portable, stubbing of execution for upstart spec. (authored by Daniel Pittman <daniel@puppetlabs.com>).Feb 1 2012, 7:07 PM