HomePhorge

(#6962) Move option handling into #parse_options, not #preinit.
7b4d9367b391Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#6962) Move option handling into #parse_options, not #preinit.

Logically, the extra work around option parsing for faces belongs in the
application parse_options method, not hidden in the step before. This commit
moves that to the right place and fixes the fallout from that strange early
design decision.

Along the way we unify error reporting for invalid options so that all the
code paths result in the same externally detected failures.

Reviewed-By: Matt Robinson <matt@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU7899462b2ec1: maint: whitespace cleanup for puppet/util/command_line.
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPU7b4d9367b391: (#6962) Move option handling into #parse_options, not #preinit. (authored by Daniel Pittman <daniel@puppetlabs.com>).Apr 13 2011, 1:12 AM