HomePhorge

(PUP-2950) enabling rubocop Style/AndOr cop in pops directory
7b4421ca12faUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

(PUP-2950) enabling rubocop Style/AndOr cop in pops directory

This commits enables AndOr cop only in lib/puppet/pops directory. This cop
bans the use of and and or keywords in favor of && and ||. We have
chosen this directory as a test case to evaluate the utility of enabling
AndOr on the complete codebase. We inherit from the base rubocop file, so all
the other cops remain enabled. At a future date, when AndOr is enabled
systemwide, this file may be removed (if no other specialization exists on pops
directory).

It changes all code that uses and and or keywords to use && and
|| instead. Note that this commit only fixes the lib/puppet/pops directory.

Details

Provenance
Rahul Gopinath <rahul@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUef75f4c11a4c: (PUP-2950) Fix: ensure that default layer is used when the user has not…
Branches
Unknown
Tags
Unknown

Event Timeline

Rahul Gopinath <rahul@puppetlabs.com> committed rPU7b4421ca12fa: (PUP-2950) enabling rubocop Style/AndOr cop in pops directory (authored by Rahul Gopinath <rahul@puppetlabs.com>).Aug 6 2014, 12:42 AM