HomePhorge

maint: stop stubbing log level setting.
7b3744cd363cUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

maint: stop stubbing log level setting.

The underlying problem turned up when another test (as a side effect) changed
the logging level to be more verbose, and a very distant test broke. This
revealed that we didn't preserve that global state around tests.

Fixing that further revealed that we stubbed setting that log level all over
the place, as a point fix for the same problem, and to assert the operation of
various tools.

So, additionally, we strip out all that stubbing, and assert on the desired
effect rather than the mechanism for achieving it.

Reviewed-By: Max Martin <max@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU220f3086e025: Move tests from Puppet-acceptance repo
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPU7b3744cd363c: maint: stop stubbing log level setting. (authored by Daniel Pittman <daniel@puppetlabs.com>).Apr 21 2011, 12:23 AM