HomePhorge

(PUP-3621) Add search_paths and list to Cached environment loader
6b96be3ba431Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-3621) Add search_paths and list to Cached environment loader

Recent changes to the Puppet::Environments::Cached loader changed its
construction so that it was no longer a subclass of Combined. This
meant that it no longer had search_path or list functions, which are
needed by the v2 environments to list known directory environments. We
were lacking spec coverage for this and it was caught by the
can_enumerate_environments system test.

In this commit, the Cached loader now delegates search_paths and list
calls to its @loader. Specs have been added for search_paths/list calls,
for the Combined loader in general, and for get_conf in Cached.
Accessors were added to EnvironmentConf for some of its internal
attributes so that it can more easily be tested.

Details

Provenance
Josh Partlow <joshua.partlow@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU1d8f7e3e6308: Merge pull request #3287 from hlindberg/PUP-3635_add-scanf-function
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Partlow <joshua.partlow@puppetlabs.com> committed rPU6b96be3ba431: (PUP-3621) Add search_paths and list to Cached environment loader (authored by Josh Partlow <joshua.partlow@puppetlabs.com>).Nov 11 2014, 10:02 PM