HomePhorge

(#7290) Fail on unknown options.
69b4e70ac2faUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#7290) Fail on unknown options.

Part of the "social contract" of Faces, Actions and Options is that the
metadata we collect is authoritative: it covers everything that is possible.

In the initial release we didn't enforce that around options. If you passed
an unknown option in the hash, we just silently ignored it in validation and
made it available down in the action.

Now, instead, we enforce that rule. If you pass an unknown option we raise an
error and complain; anything that gets to the action will be listed in the set
of inspectable options.

Cases that depended on this behaviour to pass arbitrary content in the hash
should be rewritten to move that content down a level: take a hash value for
one option, and use that for your free content.

Reviewed-By: Pieter van de Bruggen <pieter@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU6bec2df0860b: (#8561) Use canonical names for options to actions.
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPU69b4e70ac2fa: (#7290) Fail on unknown options. (authored by Daniel Pittman <daniel@puppetlabs.com>).Jul 23 2011, 1:27 AM