HomePhorge

(maint) Fix spec for UTF-8 strings in user comment properties
69a40519dae4Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(maint) Fix spec for UTF-8 strings in user comment properties

The first problem with this spec is that it wasn't actually
being run due to an always false "if" clause. It was checking
for String responding to encode, but encode is an instance
method. method_defined? should have been used instead.

The second problem with this spec is that the test value did not
contain any non-ASCII characters. If it had, it would have caught
the bug described in PUP-1473. Added a non-ASCII character to test
for regressions.

Details

Provenance
Peter Huene <peter.huene@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUf37263681cec: Merge remote-tracking branch 'upstream/stable'
Branches
Unknown
Tags
Unknown

Event Timeline

Peter Huene <peter.huene@puppetlabs.com> committed rPU69a40519dae4: (maint) Fix spec for UTF-8 strings in user comment properties (authored by Peter Huene <peter.huene@puppetlabs.com>).Feb 15 2014, 2:48 AM