HomePhorge

(#5931) Prevent errors when calling insync? on audited properties
67e1bba154acUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#5931) Prevent errors when calling insync? on audited properties

Created a method safe_insync? which first checks whether the property
has a "should" value of nil, and if so returns true. Most insync?
methods were already doing this, but a few were not, leading to bugs
if a property was being audited but not set.

Types should continue to override the insync? method, but callers of
insync? should call safe_insync? instead.

Paired-with: Jesse Wolfe <jesse@puppetlabs.com>

Details

Provenance
Paul Berry <paul@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU0f9d23617e41: Maint: Removed dead code from resource harness.
Branches
Unknown
Tags
Unknown

Event Timeline

Paul Berry <paul@puppetlabs.com> committed rPU67e1bba154ac: (#5931) Prevent errors when calling insync? on audited properties (authored by Paul Berry <paul@puppetlabs.com>).Jan 26 2011, 12:12 AM