HomePhorge

Eliminate `symbolize` everywhere, and remove it.
65b5c5cf1dc3Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Eliminate symbolize everywhere, and remove it.

The whole symbolize API was confusing and complex: because it didn't do any
type enforcement, just passed through arbitrary data, we had very unclear API
in a whole pile of places.

This replaces that method entirely with a more rigid definition: we intern in
a bunch of places, add the occasional clear failure mode, and then delete the
original definition.

This eliminates one point of complexity from the codebase.

(These other uses have no notable performance penalty, just code complexity
and clarity issues.)

Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>

Conflicts:

lib/puppet/parser/functions.rb
lib/puppet/provider.rb
lib/puppet/provider/nameservice/directoryservice.rb

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
Andrew Parker <andy@puppetlabs.com>Committed on Oct 26 2012, 12:32 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU3cda4f411793: (#16791) Revert "Merge branch 'feature/2.7.x/json-terminus-backport' of https…
Branches
Unknown
Tags
Unknown

Event Timeline

Andrew Parker <andy@puppetlabs.com> committed rPU65b5c5cf1dc3: Eliminate `symbolize` everywhere, and remove it. (authored by Daniel Pittman <daniel@puppetlabs.com>).Oct 26 2012, 12:32 AM