HomePhorge

(PUP-744) Refactor to use Net::HTTP factory
658e4fd34de9Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-744) Refactor to use Net::HTTP factory

Previously, puppet connections were directly responsible for creating
Net::HTTP objects. This was okay because there was only one code path
where new Net::HTTP objects needed to be created.

However, in order to support different connection pool behaviors,
caching and non-caching of Net::HTTP objects, we want to have two pool
implementations, and each of them will need the ability to create
Net::HTTP objects.

This commit creates a factory object for creating Net::HTTP objects,
and has the puppet connection delegate to it.

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU34171db1244e: (PUP-744) Create an HTTP session
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPU658e4fd34de9: (PUP-744) Refactor to use Net::HTTP factory (authored by Josh Cooper <josh@puppetlabs.com>).Jul 25 2014, 6:36 PM