HomePhorge

(#21427) Do not send arrays as YAML in query params
6353ebbbc0d3Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#21427) Do not send arrays as YAML in query params

Previously, when the REST requests were constructed and one of the
parameters was an Array, the Array was encoded as YAML and then
identified on the master and parsed as YAML. This was used specifically
to send the list of "ignores" when making file metadata requests.

This changes the system to now use multi-valued query parameters instead
of YAML. Both the agent and master have been updated to support this,
however existing masters will not be able to understand the new requests
correctly since they will either:

  • in webrick only choose the first value as the value of the parameter
  • in rack fail because the decode_params method does not understand arrays as values

Details

Provenance
Andrew Parker <andy@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU8398ec3b6ad0: (Maint) Test that the query string is parsable
Branches
Unknown
Tags
Unknown

Event Timeline

Andrew Parker <andy@puppetlabs.com> committed rPU6353ebbbc0d3: (#21427) Do not send arrays as YAML in query params (authored by Andrew Parker <andy@puppetlabs.com>).Jun 28 2013, 1:29 AM