HomePhorge

[#4287] Fix the undefined evaluate_match error when comparing functions
539d71635132Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

[#4287] Fix the undefined evaluate_match error when comparing functions

Ticket #4238 introduced a problem that a function couldn't compare to
another value until after it was evaluated, and AST::Function didn't have the
evaluate_match method. This change moves that method from AST::Leaf to AST.

The special casing necessary for doing comparisons between AST objects
feels messy and could probably be encapsulated better. I've created
ticket #4291 to remind us to refactor this at some point.

Paired with: Nick Lewis

Signed-off-by: Matt Robinson <matt@puppetlabs.com>

Details

Provenance
Matt Robinson <matt@puppetlabs.com>Authored on
Markus Roberts <Markus@reality.com>Committed on Jul 20 2010, 4:56 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUd2da1d45aaf4: Tweak to tweak to fix for #4233 -- ":" is valid in type names
Branches
Unknown
Tags
Unknown

Event Timeline

Markus Roberts <Markus@reality.com> committed rPU539d71635132: [#4287] Fix the undefined evaluate_match error when comparing functions (authored by Matt Robinson <matt@puppetlabs.com>).Jul 20 2010, 4:56 AM