HomePhorge

(#10614) Detect when trying to managing ACLs on a non-ACL volume
4f03384dc04fUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#10614) Detect when trying to managing ACLs on a non-ACL volume

Previously, when managing owner, group, and/or mode on a file whose
volume does not support ACLs, Puppet would raise an error when trying
to get/set the ACL.

This commit allows a file provider to optionally perform validation of
the resource. On Windows, the provider ensures that if owner, group,
and/or mode are being managed, but the underlying volume does not
support ACLs, then we fail early with an appropriate error message.

This is a noop for the POSIX file provider as no validation is
required.

File.expand_path uses the current working directory to generate
absolute paths. This was causing failures when running the specs from
a mapped network drive, e.g. HGFS, since the volume does not support
ACLs. This commit changes these tests to use make_absolute method
instead, and changes that method to always use the local 'C:\' volume.

Paired-with: Nick Lewis <nick@puppetlabs.com>

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
Jacob Helwig <jacob@puppetlabs.com>Committed on Nov 11 2011, 9:23 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU37b9f0f1c9ce: (#10614) Provide default metadata values for Windows ACLs
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPU4f03384dc04f: (#10614) Detect when trying to managing ACLs on a non-ACL volume (authored by Josh Cooper <josh@puppetlabs.com>).Nov 11 2011, 9:23 PM