HomePhorge

(PUP-3564) Suppress empty pkg certificate warnings
49c5dab679b5Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-3564) Suppress empty pkg certificate warnings

Commit aae6e938 issued a warning if pkg list -Hn <name> returned lines
of the form /^Certificate/, but Array#select returns an empty array if
nothing matches, instead of nil. So the if cert_warnings condition was
always true, causing the pkg provider to issue messages of the form:

pkg warning: []

This commit checks for an empty array instead of nil, and adds tests to
ensure we only generate a warning when necessary.

Details

Provenance
Lauri Tirkkonen <lotheac@iki.fi>Authored on
Josh Cooper <josh@puppetlabs.com>Committed on Nov 6 2014, 6:41 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU6794115e3140: (PUP-3277) Allow resource changes in ticket 5477 test
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPU49c5dab679b5: (PUP-3564) Suppress empty pkg certificate warnings (authored by Lauri Tirkkonen <lotheac@iki.fi>).Nov 6 2014, 6:41 AM