HomePhorge

(#11740) Disable failing test on Windows
4807c6dab851Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#11740) Disable failing test on Windows

Jenkins uncovered a race condition on Windows when a parent process
tries to get the exit code of its child process. If the child exits
before the parent calls OpenProcessToken, then the parent cannot get
the child's exit code.

This issue has been present for a long time, and isn't trival to fix,
because the spec tests assume waitpid2 behaves consistently on POSIX
and Windows.

I'm disabling the test on Windows for now, and will revert this change
when I have a real fix for #11740.

Reviewed-By: Jeff McCune <jeff@puppetlabs.com>

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUf79bd374ce9c: Merge pull request #306 from glarizza/bug/2.7.x/11293_users_osx
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPU4807c6dab851: (#11740) Disable failing test on Windows (authored by Josh Cooper <josh@puppetlabs.com>).Jan 6 2012, 6:30 PM