HomePhorge

Cleanup of the Forge code
4679455a5c1bUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Cleanup of the Forge code

Removed some unreachable code that occured after an exception being
thrown. Pushed the construction of the Net::HTTP::Get object into the
repository so that it doesn't leak as much of its implementation out to
its clients.

Refactored the tests so that they include as many nested
contexts and pulled out helper methods to make the tests be more
explanatory.

Details

Provenance
Andrew Parker <andy@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU98481c8be4a0: Merge pull request #760 from pcarlisle/maint/master/remove-deprecated…
Branches
Unknown
Tags
Unknown

Event Timeline

Andrew Parker <andy@puppetlabs.com> committed rPU4679455a5c1b: Cleanup of the Forge code (authored by Andrew Parker <andy@puppetlabs.com>).May 11 2012, 10:26 PM