HomePhorge

(maint) Move methods for creating downloaders to factory
445d2f34de4fUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(maint) Move methods for creating downloaders to factory

Previously, the plugin_handler module was responsible for creating
downloaders and evaluating them. Since all of this happens within a
single method it is hard to test that the downloaders are created with
the correct set of properties. For example, we ignore source
permissions when downloading plugins, but we use source permissions
when downloading external facts, since those often contain scripts,
which must be executable.

This commit moves the logic for creating the downloaders to a factory
and updates the tests accordingly. As part of this change, the
PluginHandler module is changed to a class and is no longer mixed into
the Configurer.

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUc6ba27e2c419: Merge pull request #2934 from peterhuene/pup/2971
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPU445d2f34de4f: (maint) Move methods for creating downloaders to factory (authored by Josh Cooper <josh@puppetlabs.com>).Aug 7 2014, 9:08 AM