HomePhorge

(PUP-3718) Make it clear that exist?(varname) returns boolean
3ee53244a17bUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-3718) Make it clear that exist?(varname) returns boolean

There was a code path that did not ensure that that the return
from exist?(varname) was a boolean. Now a test is added, and nil
result is always turned into a boolean.

This is primarily done to ensure against leaking values / object
that could be considered thruthy if this code changes. (It would
be harmeless to return nil/false or true as the code stands now,
but this commit makes it explicit that a boolean result is expected.

Details

Event Timeline

Henrik Lindberg <henrik.lindberg@cloudsmith.com> committed rPU3ee53244a17b: (PUP-3718) Make it clear that exist?(varname) returns boolean (authored by Henrik Lindberg <henrik.lindberg@cloudsmith.com>).Dec 10 2014, 7:02 AM