HomePhorge

(#7523) Refactor the grammar to reduce duplication
3ac7aede7233Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#7523) Refactor the grammar to reduce duplication

This commit unifies some paths in the grammar, which had previously been
duplicated to avoid shift/reduce conflicts. Merging these paths together and
separating only the conflicting structures leads to a cleaner grammar, with
fewer holes.

Several bugs are fixed as a result:

(#3129) Nested class names beginning with numbers work correctly
(#5268) Hyphens in class names work correctly
(#5817) Hashes and arrays can now be passed to functions (hashes require parentheses)

Additionally, expressions are now legal in most places where they would make
sense, when previously only bare rvalues were allowed.

Paired-With: Markus Roberts
Reviewed-By: Matt Robinson

Details

Provenance
Nick Lewis <nick@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU99d437d2bbc2: Merge branch 'ticket/2.7.next/7114' into 2.7.next
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Lewis <nick@puppetlabs.com> committed rPU3ac7aede7233: (#7523) Refactor the grammar to reduce duplication (authored by Nick Lewis <nick@puppetlabs.com>).May 17 2011, 11:54 PM