HomePhorge

Fix to fix for #5755 -- backref serialization issues in zaml
392504a1eb49Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix to fix for #5755 -- backref serialization issues in zaml

This commit addresses the original issue that the change reverted in the previous
commit for #5755 was intended to fix by removing the special case on labels in
emit (lables, even if they are never generated, are not "new lines" and thus
@recent_nl should always be set to false when one is emitted).

It also partially addresses a related issue wherein temporary strings generated
when field names are constructed recycle their object_id (they are temporary)
and thus cause incorrect back references. This commit "fixes" the problem by
never generating backrefs to strings (treating them as immutable).

It does not address other suspected issues such as thread safety durring serialization
due to the use of class variables to store the seen-object hash or the use of object
ids as "permanently unique" identifiers.

Paired with: Daniel Pittman
Advice & Commiseration: Jesse Wolfe

Details

Provenance
Markus Roberts <Markus@reality.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUadb8c7994ea7: Merge branch '2.6.next' of git://github.com/puppetlabs/puppet into 2.6.next
Branches
Unknown
Tags
Unknown

Event Timeline

Markus Roberts <Markus@reality.com> committed rPU392504a1eb49: Fix to fix for #5755 -- backref serialization issues in zaml (authored by Markus Roberts <Markus@reality.com>).Feb 2 2011, 1:48 AM