HomePhorge

(#6770) Don't pollute valid face list when #face? is called.
36021021b4cbUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#6770) Don't pollute valid face list when #face? is called.

We had two conflicting uses of the list of available faces: in the #face?
method we were perfectly happy to create a top level key on any request, but
didn't populate the version set.

Meanwhile, in #faces we treated the set of top level keys as the absolute and
correct list of all *valid* faces, leading to pain and suffering when people
queried for an invalid face, but then expected to enumerate only valid faces.

Paired-With: Matt Robinson <matt@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU14b1e008c136: (#6992) Expose available_subcommands as a class method.
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPU36021021b4cb: (#6770) Don't pollute valid face list when #face? is called. (authored by Daniel Pittman <daniel@puppetlabs.com>).Apr 13 2011, 1:12 AM