HomePhorge

(#7632) Make secret_agent application compatible with secret_agent face
31bf55c2f9c0Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#7632) Make secret_agent application compatible with secret_agent face

Running puppet secret_agent was failing with an error in validate_args (in
interface/action.rb), because the application was trying to pass the certname as
an argument to the synchronize action. Also, it was trying to submit the report
a second time. Reviewing the code with Nick0, we found that the application
wasn't inheriting from FaceBase and was duplicating a lot of work, and were able
to resolve the issue by basically deleting the whole thing.

This patch makes secret_agent behave like the other Faces apps, and makes
synchronize the default action of the secret_agent face. We left the `run_mode
:agent` line in the application because of bug #7802.

Paired-with: Nick Lewis <nick@puppetlabs.com>

Details

Provenance
nfagerlund <nick.fagerlund@gmail.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUc5448b79e690: (#7624) Auditing should not be enabled by default for purged resources.
Branches
Unknown
Tags
Unknown

Event Timeline

nfagerlund <nick.fagerlund@gmail.com> committed rPU31bf55c2f9c0: (#7632) Make secret_agent application compatible with secret_agent face (authored by nfagerlund <nick.fagerlund@gmail.com>).Jun 6 2011, 10:43 PM