HomePhorge

(maint) Remove inheritance to make mistakes less likely
2b1f8e8d5b71Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(maint) Remove inheritance to make mistakes less likely

The previous mistake happened partly because the classes were written
with inheritance rather than delegation. The inheritance caused the
Combined#get! implementation to be used, which was appropriate for it,
but not for the Cached get. The Cached implementation also has no reason
to allow multiple loaders, instead it only needs a single loader and
multiple ones can be put together using the Combined loader. This change
makes that distinction much clearer.

Details

Provenance
Andrew Parker <andy@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUec6b48d7ac85: (PUP-3621) Ensure that get! caches
Branches
Unknown
Tags
Unknown

Event Timeline

Andrew Parker <andy@puppetlabs.com> committed rPU2b1f8e8d5b71: (maint) Remove inheritance to make mistakes less likely (authored by Andrew Parker <andy@puppetlabs.com>).Nov 7 2014, 8:38 PM